search

citation-file-format / cffconvert

Command line program to validate and convert CITATION.cff files.
Apache License 2.0
100 stars 28 forks source link

Make compatible with jsonschema 4 #292

Open johentsch opened 1 year ago

johentsch commented 1 year ago

Hi folks,

currently cffconvert downgrades jsonschema to 3.2.0 upon pip install. This makes Jupyter notebook and lab fail with a ModuleNotFoundError: No module named 'jsonschema.protocols' error.

This means that users who have the current versions of jupyter installed need to create a new environment for cffconvert specially. This could be avoided by making the code compatible with jsonschema==4.

jspaaks commented 1 year ago

Hi @johentsch, thanks for the report. The jsonschema compatibility is a known issue, I just haven't been able to find some time to look into it but hopefully it won't be too long before this is fixed.

jspaaks commented 1 year ago

Related discussion: https://github.com/citation-file-format/cff-converter-python/pull/281#issuecomment-1622395770

jspaaks commented 1 year ago

Note this was updated in main, but it's not released yet.

maxnoe commented 5 months ago

As jupyter is no requiring jsonschema >= 4, it would be great to have a release to be able to have jupyter and cffconvert in the same environment