search

citation-file-format / doi2cff

Generate a CFF file using the metadata from a software release on Zenodo.
Apache License 2.0
22 stars 4 forks source link

changed the message in order to be able to deal with yamllinters (who… #9

Closed jspaaks closed 5 years ago

jspaaks commented 5 years ago

… sort by keyname and thereby mess with what is 'below')

jspaaks commented 5 years ago

I forgot to mention I could not get the tests to work locally (not using mkvirtualenv like described here https://doi2cff.readthedocs.io/en/latest/contributing.html#types-of-contributions, tried to use virtualenv instead...no success)

sverhoeven commented 5 years ago

Without successful Travis I can not merge the PR. Can you try to install locally using pipenv? 

pipenv --three shell
pip install -e . -r requirements_dev.txt
doi2cff --help
sverhoeven commented 5 years ago

Without successful Travis I can not merge the PR. Can you try to install locally using pipenv? 

pipenv --three shell
pip install -e . -r requirements_dev.txt
doi2cff --help
jspaaks commented 5 years ago

understandable. I tried 

cd $(mktemp -d)
pip install --user pipenv
pipenv --three shell
git clone https://github.com/citation-file-format/doi2cff.git
cd doi2cff/  
pip install -e . -r requirements_dev.txt
doi2cff --help # works yay
git checkout message
py.test  # errors about pluggy being the wrong version

so tool seems to work but pytest fails

sverhoeven commented 5 years ago

Can you merge changes from master branch? This should fix the pytest version conflict.

Slighly altered instuctions in CONTRIBUTIONS.rst

pipenv install -e . -r requirements_dev.txt
pipenv shell
pytest
jspaaks commented 5 years ago

for the record, I did

pipenv --three shell
pipenv install -e . -r requirements_dev.txt

(hung in the last step, 

Adding doi2cff to Pipfile's [packages]…
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…

) let's see if/how the travis fails. Update: looks like that works...well fails normally.

jspaaks commented 5 years ago

tried following the instructions more better this time

# cd <my doi2cff>
# new terminal
pipenv --rm
pipenv install -e . -r requirements_dev.txt
pipenv shell
pytest
# runs the test (but fail, yay)
jspaaks commented 5 years ago

All good, over to you.