Closed fmigneault closed 1 week ago
Hi @fmigneault and thanks for making the issue. I looked into it and it seems related to the use of anchors. At least, when I replace the *authors
and *crim
with the data it references, it seems to work correctly.
I believe this could be a bug in ruby-cff
, the library that GitHub uses to render CITATION.cff
files on their website. Let me ping @hainesr for you. Rob created and maintains said library. I'll also move this issue there.
Hope this helps!
Hello,
Yes, it's the anchors. It turns out that the underlying Ruby library that handles YAML doesn't process anchors by default, perhaps as a security precaution.
I will enable this and see how it goes. I'll cut a new release and notify GitHub if all is well.
I have fixed this and pushed version 1.3.0 of the gem.
@arfon, please can you let the relevant people at GitHub know that there's a new release of the Ruby CFF gem? Thanks!
Thanks for the ping @hainesr. I've opened a PR on github/github to update this but it likely won't land until the end of the week as there's a deploy block for a few days during GitHub Universe.
Great, thanks @arfon.
@fmigneault please can I suggest you try your file on GitHub again in a couple of weeks?
@hainesr @fmigneault – the latest version of ruby-cff is now live on GitHub.com. Could you confirm your issue is now addressed?
Yes. The file is correctly parsed and the citation option is rendered on the main repo page. Thanks for the quick fix.
Amazing 🚀
Thanks @arfon for the quick turnaround and thanks @fmigneault for testing.
Please note that issues with the validity of single CITATION.cff files may take some time to be picked up by the Citation File Format maintainers themselves. Therefore, if you are reading this issue and know how to validate
CITATION.cff
files, please help out if you can!Invalid
CITATION.cff
fileThe file can be found here: https://github.com/stac-extensions/mlm/blob/main/CITATION.cff
Context
Running the validation tool
I get NO error!
Yet, GitHub still indicates it cannot be parsed.
Therefore, my question. Which once is correct? The official validation tool or GitHub? Thanks