search

citation-js / plugin-software-formats

Collection of software-related input and output formats for Citation.js
MIT License
4 stars 2 forks source link

'.' should be escaped in regular expressions for hostnames #12

Closed fnielsen closed 2 years ago

fnielsen commented 2 years ago

predicate: /^https?:\/\/api.github.com\/repos\/[^/]+\//, should probably be predicate: /^https?:\/\/api\.github\.com\/repos\/[^/]+\//,.

The same for predicate: /^https?:\/\/registry.npmjs.org\//,

See https://github.com/WDscholia/scholia/pull/1939/files

larsgw commented 2 years ago

Thank you for the report. I released a fix in v0.5.3 and I can create a PR to update Scholia.

fnielsen commented 2 years ago

Thanks for the PR!