Closed rmzelle closed 4 years ago
I agree, sorting is case-insensitive. LGTM.
Adding a couple of reviewers.
Obviously if we merge, the merge conflict would need to be resolved. I think a get merge master
will fix it, as it's probably just because I changed the file extension.
This is probably a super rare edge case with little to no practical relevance for names, but in German there seems to exist a rule that says: if you have two words with the same letters, lowercase comes first.
But that's so rare we can probably just ignore that for now unless that bites someone...
@bdarcus Are we good to merge this? If so, I'll resolve the conflicts and merge.
Yes.
BTW, I wonder if at some point we should do as Dan h did on the schema readme; convert this document to "one sentence per line."
Would make the diffs better.
So "one sentence per line" instead of "80 characters per line"?
Yeah. We'd obviously want to talk about that with Rintze, etc. before pulling the trigger.
I guess I don't have a strong preference one way or the other. Aesthetically, I like 80 characters, but I can see the diff-related benefit for sentence/clause-based.
@adam3smith, @bdarcus, and @fbennett all agree that sorting should be case-insensitive, so I made note of it in the spec. See https://github.com/citation-style-language/styles/issues/189#issuecomment-6665919
I'll accept this pull request once people have had a chance to review.