Update cs:group formatting attribute treatment

citation-style-language / documentation

Citation Style Language documentation

http://citationstyles.org/

Creative Commons Attribution Share Alike 4.0 International

43 stars 21 forks source link

Update cs:group formatting attribute treatment #34

Closed inukshuk closed 4 years ago

inukshuk commented 10 years ago

See the discussion at: http://xbiblio-devel.2463403.n2.nabble.com/Group-formatting-td7578925.html

bdarcus commented 4 years ago

Bumping.

Obviously if we merge, the merge conflict would need to be resolved. I think a get merge master will fix it, as it's probably just because I changed the file extension.

Other option, for some of these old PRs, is we can merge to a branch, and fix there.

bdarcus commented 4 years ago

Anyone want to propose resolution to this and the related linked issue?

fbennett commented 4 years ago

My views and the reasoning behind them are set down in https://github.com/citation-style-language/documentation/issues/65:

cs:choose itself should not be treated as a "rendering element;" and
formatting attributes on cs:group should be applied to the group as a whole, and not "transmitted" to its children.

Styles in the CSL repository are based on these assumptions.

bwiernik commented 4 years ago

See the PR here: https://github.com/citation-style-language/documentation/pull/116