search

citation-style-language / journals

Tools and journal metadata for generating dependent CSL styles
MIT License
50 stars 30 forks source link

Create Mary Ann Liebert dependent styles #127

Closed POBrien333 closed 2 years ago

POBrien333 commented 2 years ago

in addition to https://github.com/citation-style-language/styles/pull/5957

This is in communication with the publisher and a list was provided to me.

POBrien333 commented 2 years ago

Hi @adam3smith I'm aware you're very busy these days. Would you be able to look at this PR though in the coming days as I'd like to close this project with Heather. Thank you :)

bwiernik commented 2 years ago

Lgtm. Thanks!

POBrien333 commented 2 years ago

Ahh, you're a star. Thanks, Brenton! :)

POBrien333 commented 2 years ago

It looks like the styles are not appearing on the repository. Who do we need to ask to get that looked into?

bwiernik commented 2 years ago

@retorquere Anything amiss with the actions?

POBrien333 commented 2 years ago

Hi @retorquere Sorry for following up on this so soon again, but were you able to look into this issue? Thank you.

retorquere commented 2 years ago

Sorry, this had entirely slipped my attention, I'll look into it this afternoon.

retorquere commented 2 years ago

The journals repo don't have any kind of merge logic, only the styles and locales repos do. Should the journals repo behave like locales?

This might require changes to Sheldon. At some point we're going to have to overhaul Sheldon. There's a lot of cruft, and I'm just not really current on ruby.

adam3smith commented 2 years ago

I don't think we want to automate this: good to have a human eye on this before merging -- someone actually has to run the sync script locally and the push the changes. I'm afraid that won't be me until later this week

retorquere commented 2 years ago

So nothing to do for me here?

adam3smith commented 2 years ago

No, sorry. Thanks for checking and sorry for the false alarm.

POBrien333 commented 2 years ago

Ahh. Great. Thanks for looking into this. I'll wait till you let me know when you've ran the script then. thx