Closed zuphilip closed 9 years ago
the problem with taking these all out in a blanket fashion is that if one of the elements is missing you may need the space in the other one and vice versa.
I don't understand the term "blanket fashion" here, but if you want to say we should be cautious, then I agree. Maybe it helps to look closer at the occuring patterns. One such pattern (edition + publisher) looks like this
<if type="bill book graphic legal_case legislation motion_picture report song" match="any">
<text macro="edition" prefix=" " suffix=" "/>
<text macro="publisher" prefix=" "/>
</if>
I would suggest to replace the above pattern with
<if type="bill book graphic legal_case legislation motion_picture report song" match="any">
<group prefix=" " delimiter=" ">
<text macro="edition"/>
<text macro="publisher"/>
</group>
</if>
Other patterns I have found:
I think we should go over all occurrences and fix it in each case seperately. I think I could do that (at least for most of the styles). Do you have any guidelines or general advice on such a procedure? I prefer normally groups more than prefix/suffix, but sometimes (I guess) it is not necessary and maybe just delete the prefix-space is enough. Which way would be the easiest for you to review: one large pull request, individual pull request for every style, or something between?
"Not in a blanket fashion" heißt sowas wie "nicht grossflaechig ohne genauer zu gucken" so you did understand that correctly.
As you know, I generally agree with your approach to prefer groups to affixes, both in general and in your specific example.
The easiest to review for me would be one pull request for every type of change -- i.e. all styles with the edition/publisher macro in a single pull request, etc. Thanks and gutes Neues Jahr!
@zuphilip, can we close this now?
Don't close it yet. There are still more adjacent spaces which I would like to delete (currently I count 76 occurencies in 47 styles). It just takes time because I look at each case individually.
closed per above commits
Sometimes there is a double space coded in citation styles: