Closed dhimmel closed 5 years ago
I wouldn’t pay any attention to that example. Journal articles in PLOS journals don’t generally, if ever, include publishers. There is no reason for the inconsistency in the examples here.
Note that container-title
is the title of the journal, so the conditional you propose would always be true.
@bwiernik -- I don't understand (or maybe you're misreading the issue -- the example with publisher is not from PLOS but from our style for PLOS). It's not uncommon for journal article metadata to include the publisher (pubmed, CrossRef). In some countries (such as Brazil) it's even included in the citation. The problem is that our styles have assumed for a very long time the Zotero data model which doesn't have a publisher for journal articles and so we're getting this.
I'd add a much more general publisher conditional that removes it entirely from journal, magazine, and newspaper articles (at a minimum)
Yes, that’s right. Sorry—I misread the issue as quoting example citations.
Cleaning up old GitHub notification emails. Thanks @POBrien333 for resolving this in https://github.com/citation-style-language/styles/pull/4191.
Noting that we've encountered some additional issues with the PLOS CSL style, described at https://github.com/citation-style-language/styles/issues/4138 and https://github.com/greenelab/meta-review/pull/241#issuecomment-501252429. Some of the issues like including [Preprint]
after the preprint repository name are likely not possible given the current types supported by CSL Data Items.
Ideally journals would produce the styles themselves and use it as the reference implementation of how the styles should behave. But until then, thanks to volunteers like @POBrien333 and @adam3smith for doing the hard work!
PLOS Computational Biology (and PLOS) show an example journal article reference of:
Note that publisher information is not included (at least when
container-title
is known). However, we find here that the publisher is included (in this case "Oxford University Press"):The CSL for this item is:
Is it possible for the following to be conditional, in a way that would omit showing publisher when type is
article-journal
andcontainer-title
is available:https://github.com/citation-style-language/styles/blob/76e2ff8e518bd8623b48e31e1c70ff4ffb66217b/plos.csl#L305