citation-style-language / styles

Official repository for Citation Style Language (CSL) citation styles.
https://citationstyles.org/
3.27k stars 3.76k forks source link

Fixes for Journal of Egyptian Archaeology #5969

Closed jfrmasters closed 2 years ago

jfrmasters commented 2 years ago

Thanks for earlier fix on page numbers. Other issues that I've since noticed...

First ref is like this: M. I. Smith, ‘A Tapestry in the tomb of Horus’, in Janice Kamrin, Miroslav Barta, Salima Ikram, Mark Lehner, Mohamed Megahed (ed.), Guardian of Ancient Egypt, II (Prague, 2020), 659–71, at 662.

But (1) the editors should have initials, not their full names And (2) Single editor is ed. but multiple should be eds without the '.'.

2nd is: Khaled, in Janice Kamrin, Miroslav Barta, Salima Ikram, Mark Lehner, Mohamed Megahed (ed.), Guardian of Ancient Egypt, 663.

But (3) subsequent authors/editors show surname only And (4) subsequent multiple authors/editors should list first only followed by 'et al.'

So I think latter should be:

Khaled, in Kamrin et al. (eds), Guardian of Ancient Egypt, 663.

Thanks for time spent on this.

POBrien333 commented 2 years ago

Hi,

Since you were already digging into the guidelines, always easier to cite the specific parts you found, as it's easier for us to then just confirm those rather than search for them ourselves. ;)

1) chapter, editor names: Can't reproduce and renders correctly: I. Mares, ‘Firms and the welfare state: When, why, and how does social policy matter to employers?’, in P. A. Hall and D. Soskice (eds.), Varieties of capitalism. The institutional foundations of comparative advantage (New York, 2001), 184–213, at 244–52.

2) editor labels, singular, plural: fixed to "ed." and "eds"

3) chapter subsequent author name: it already ONLY shows the surname: Mares, in Hall et al. (eds), Varieties of capitalism. The institutional foundations of comparative advantage, 184–213.

4) chapter subsequent editors: editors set to 2/1

(guidelines: https://journals.sagepub.com/pb-assets/cmscontent/EGA/JEA_Referencing_Style.pdf)

POBrien333 commented 2 years ago

@jfrmasters The PR just got merged. Let us know if you had any more comments/amendments.

jfrmasters commented 2 years ago

Thankyou for your swift action and apologies - I was entering the names incorrectly it appears. Having now finished all my refs, I think there are 3, possibly 4 more bugs viz:

many thanks

jfrmasters commented 2 years ago

I have fixed 3 problems but the conference paper double title still exists. I have emailed you my updated file. Hope this helps.

bwiernik commented 2 years ago

@POBrien333 what’s the status of this?

POBrien333 commented 2 years ago

I've just added one edit in a new PR, but I'm not willing to further work on this style due to the guidelines being a mess amongst other things. OP seems to know CSL well enough anyway.

bwiernik commented 2 years ago

Okay, closing for now. @jfrmasters please feel free to submit a new PR if additional changes are needed.