citation-style-language / styles

Official repository for Citation Style Language (CSL) citation styles.
https://citationstyles.org/
3.33k stars 3.78k forks source link

Issues with locales when updating styles #6101

Closed fussballlinguist closed 2 years ago

fussballlinguist commented 2 years ago

I tried to do some updating of existing styles in the repo (see pull requests #6097, #6098). They all do not pass the automatic checks because of some problems with the locales, although I did not any changes in that part of the styles.

The error messages look like this:

Run bundle exec rake
  bundle exec rake
  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
Running tests from /home/runner/work/styles/styles
/opt/hostedtoolcache/Ruby/3.0.[2](https://github.com/citation-style-language/styles/runs/6994545167?check_suite_focus=true#step:11:2)/x64/bin/ruby -I/home/runner/work/styles/styles/vendor/bundle/ruby/[3](https://github.com/citation-style-language/styles/runs/6994545167?check_suite_focus=true#step:11:3).0.0/gems/rspec-core-3.10.1/lib:/home/runner/work/styles/styles/vendor/bundle/ruby/3.0.0/gems/rspec-support-3.10.3/lib /home/runner/work/styles/styles/vendor/bundle/ruby/3.0.0/gems/rspec-core-3.10.1/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb --require spec_helper.rb --format Fuubar --color --format json --out spec/sheldon/ci.json
Loading dependent styles matching . in /home/runner/work/styles/styles/pull-request/dependent/*.csl..................................................................
Loading independent styles matching . in /home/runner/work/styles/styles/pull-request/*.csl.....................
Progress: |====
  1) developmental-dynamics: must validate against the CSL 1.0.1 schema
     Please check your style at http://validator.citationstyles.org/
     Failure/Error: expect(CSL.validate(path)).to be_empty
       expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false
     Shared Example Group: "style" called from ./spec/styles_spec.rb:216
     # ./spec/styles_spec.rb:5:in `block (2 levels) in <top (required)>'
Progress: |====================================================================|
Finished in 1 minute [4](https://github.com/citation-style-language/styles/runs/6994545167?check_suite_focus=true#step:11:4).99 seconds (files took 43.[5](https://github.com/citation-style-language/styles/runs/6994545167?check_suite_focus=true#step:11:5)5 seconds to load)
172412 examples, 1 failure
Failed examples:
rspec './spec/styles_spec.rb[5[6](https://github.com/citation-style-language/styles/runs/6994545167?check_suite_focus=true#step:11:7)6:1]' # developmental-dynamics: must validate against the CSL 1.0.1 schema
     Please check your style at http://validator.citationstyles.org/
/opt/hostedtoolcache/Ruby/3.0.2/x64/bin/ruby -I/home/runner/work/styles/styles/vendor/bundle/ruby/3.0.0/gems/rspec-core-3.[10](https://github.com/citation-style-language/styles/runs/6994545167?check_suite_focus=true#step:11:11).1/lib:/home/runner/work/styles/styles/vendor/bundle/ruby/3.0.0/gems/rspec-support-3.10.3/lib /home/runner/work/styles/styles/vendor/bundle/ruby/3.0.0/gems/rspec-core-3.10.1/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb --require spec_helper.rb --format Fuubar --color --format json --out spec/sheldon/ci.json failed
Error: Process completed with exit code 1.
adam3smith commented 2 years ago

Issue is with one broken style that got fixed, you can ignore it or rebase against upstream/master if you want to pass CI