search

citation-style-language / test-suite

11 stars 13 forks source link

Remove variable call from macro #33

Closed bdarcus closed 4 years ago

bdarcus commented 4 years ago

I'm not really sure if this is right, but ...

Except in rare cases, macros that render more than one element should be avoided as sort keys, as they can lead to unexpected sorting in edge cases. Instead, use their elements as individual, consecutive sort keys.

Closes #31

adam3smith commented 4 years ago

Thanks! That sentence (or a version of it) was intended for the specifications, though.

bdarcus commented 4 years ago

Did you fix it (by squash merging)?

adam3smith commented 4 years ago

I think that worked correctly, yes.