search

citation-style-language / test-suite

11 stars 13 forks source link

Move `citation-number` test that depend on off-spec behavior to `off-spec` folder (v2) #65

Closed Jason-Abbott closed 1 year ago

Jason-Abbott commented 1 year ago

[Re-PR’d from branch (compare #64)]

Per conversation in https://github.com/citation-style-language/test-suite/issues/53#issuecomment-1588422238

Tests that show a reversed citation-number depend on overloaded behavior not defined in the specification. I left in place citation-number tests that show an ascending citation-number. I think those are basically no-ops anyway.

I considered updating processor.py with an argument to optionally include this folder but I’m not sure how often it’s used. It didn’t look like it was updated for the processor-tests/humans/experiments folder so maybe not needed.

Jason-Abbott commented 1 year ago

This adds a couple tiny changes where I simply added the == DESCRIPTION == markers around existing comments

bdarcus commented 1 year ago

For whatever reason, I still couldn't rebase (maybe because you had a merge commit?), but I was able to squash it all.

Thanks!