search

citerus / dddsample-core

This is the new home of the original DDD Sample app (previously hosted at sf.net)..
MIT License
4.98k stars 1.47k forks source link

Fix Instant parsing issue #136

Closed kingsleylong closed 6 months ago

kingsleylong commented 6 months ago

Why

Fix issue #99 error parsing fromDate and toDate in RouteAssignmentCommand.LegCommand.

What

  1. Change the input param to String in the setters of fromDate and toDate.
  2. Change the date value in thyme leaf page to the original value.
  3. In the setters, use Instant.parse() to parse the date time in ISO-8601 instant format.
  4. Added selenium tests for cargo routing, which tests this change.
  5. Set locale to US in CargoTrackingRestServiceIntegrationTest so they can run in non-US regions.
kingsleylong commented 6 months ago

@orende could you please review this PR? Thanks!

orende commented 6 months ago

Thank you for the PR!

kingsleylong commented 6 months ago

@orende My pleasure! Could you help to merge the PR as I don't have write access to the repo?

orende commented 6 months ago

Merged! :heavy_check_mark: