search

citerus / dddsample-core

This is the new home of the original DDD Sample app (previously hosted at sf.net)..
MIT License
4.97k stars 1.47k forks source link

Selenium 1 #17

Closed andeemarks closed 6 years ago

andeemarks commented 7 years ago

Hi folks,

I noticed you had an E2E acceptance card on your Trello at https://trello.com/c/Pic0oq3Y/25-end-to-end-acceptance-testing.

This branch contains a starting set of Selenium tests for the Customer and Admin sites. I haven't done anything around routing yet, but basic adding of cargo is all covered.

jostly commented 7 years ago

Good initiative! Please make sure you revert the change to the Readme that points to the Travis CI results.

andeemarks commented 7 years ago

Oops - thanks for spotting that Johan - I'll get to it today.

Cheers, Andy

Andy MARKS Principal Consultant ThoughtWorks Melbourne mobile: 0435 318 616 email: amarks@thoughtworks.com web: www.thoughtworks.com

On 5 June 2017 at 07:18, Johan Östling notifications@github.com wrote:

Good initiative! Please make sure you revert the change to the Readme that points to the Travis CI results.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/citerus/dddsample-core/pull/17#issuecomment-306067613, or mute the thread https://github.com/notifications/unsubscribe-auth/AALKZUVsRC0lCELhr7qf0iBSdjVI8yIrks5sAx8LgaJpZM4NtvWa .

andeemarks commented 7 years ago

README is now pointing back to the citerus Travis build

andeemarks commented 7 years ago

Hi Johan,

I've added some more the routing acceptance tests recently - would you like me to commit these to the same branch to be merged as a single unit, or rebase from cirterus/master and create another branch/PR for them?

Cheers, Andy

Andy MARKS Principal Consultant ThoughtWorks Melbourne mobile: 0435 318 616 email: amarks@thoughtworks.com web: www.thoughtworks.com

On 5 June 2017 at 09:24, Andy Marks amarks@thoughtworks.com wrote:

Oops - thanks for spotting that Johan - I'll get to it today.

Cheers, Andy

Andy MARKS Principal Consultant ThoughtWorks Melbourne mobile: 0435 318 616 email: amarks@thoughtworks.com web: www.thoughtworks.com

On 5 June 2017 at 07:18, Johan Östling notifications@github.com wrote:

Good initiative! Please make sure you revert the change to the Readme that points to the Travis CI results.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/citerus/dddsample-core/pull/17#issuecomment-306067613, or mute the thread https://github.com/notifications/unsubscribe-auth/AALKZUVsRC0lCELhr7qf0iBSdjVI8yIrks5sAx8LgaJpZM4NtvWa .

mackapappa commented 6 years ago

Converted your acceptance tests to use HtmlUnit and MockMvc instead of Selenium since the sample app now uses Spring Boot. Take a look in master.