search

citerus / dddsample-core

This is the new home of the original DDD Sample app (previously hosted at sf.net)..
MIT License
4.94k stars 1.47k forks source link

Maven Surefire Plugin configuration to resolve module access issues in tests for JDK 9 and newer #77

Closed ikardovskiy closed 1 year ago

ikardovskiy commented 1 year ago

Maven Surefire Plugin configuration to resolve module access issues in tests for JDK 9 and newer

orende commented 1 year ago

@ikardovskiy After we merged another PR adding a Github Actions pipeline and rebased this PR on that, we noticed that the pipeline fails for this PR. Could these changes be related to the failure?

ikardovskiy commented 1 year ago

I'll check causes of failure today. May be I need to add version to plugin if checks made too strict

ikardovskiy commented 1 year ago

I have set explicit version to surefire plugin. Maven compile and test phases executed successfully. But it seems to me we have some security issues in CI/CD:

Error: HTTP Status 403 for request POST https://api.github.com/repos/citerus/dddsample-core/dependency-graph/snapshots
Error: Response body:
{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/dependency-graph#create-a-snapshot-of-dependencies-for-a-repository"
}
Error: Resource not accessible by integration
Error: HttpError: Resource not accessible by integration

May be it too strict for external contributors like me.

We can see it here

orende commented 1 year ago

These changes have now been incorporated into the project in commits 5aa4a76afb20546b97611884b9128680858cb8bc and 61977cf9c4c0e8cf19993972011cd0d330c2cb83 as part of another PR. Thanks!