citi-onboarding / Pratas-onepage

0 stars 0 forks source link

Contact session #28

Closed isaquetdiniz closed 4 years ago

isaquetdiniz commented 4 years ago

I finished the Contact Session and corrected some adjustments in the Footer Session.

debespindola commented 4 years ago

It's better, but still doesn't work in some screens. You could set a defined field for the contact section, because the button in invading the footer sometimes. Try to use the Google Chrome's tool to see if it's working in like Moto G, iPhone 5, etc.

isaquetdiniz commented 4 years ago

Tthank you, I think I have now managed to resolve, take a look. :)

debespindola commented 4 years ago

Isaque, I was taking a look at your code and I noticed some details you could check: 1- a imagem das pulseiras tá distorcendo (talvez seja melhor usar uma div com backgroud em vez de tag img) 2- a logo do footer ta distorcendo, apaga a height, deixa só width: 100% 3- tira o padding-bottom do botão de submit (pra alinhas o texto dentro) e coloca em port ('enviar') 4- também no botão, coloca 'cursor: pointer;', pra aparecer aquela mãozinha de clicar. (se quiser estilizar, bota um hover tb, talvez fique mais nice. lá no w3school tem umas ideias tops) 5- tenta colocar todas as infos do contato numa div pra alinhar (evitando usar margem) 6- na versão mobile o conteúdo do footer ta colado com a seção contatos 7- icones do footer na versão mobile tão grandes 8- o título "contatos" ta grande 9- vê a cor certinha dos inputs, no mockup parece mais clara 10 - tira os negritos do footer

debespindola commented 4 years ago

Great! I would only align the right using flexbox (in some responsivities it's not aligned) and change "submit" to "enviar".