citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.58k stars 2.12k forks source link

When having a .ymt scenario file in a resource the .ymt won't stream and the origional seems gone #1170

Open FlavioMoretti opened 3 years ago

FlavioMoretti commented 3 years ago

When I put a .ymt file in a resource (it doesn't matter if it is in a stream folder or just in the same folder as the fxmanifest.lua) it seems like the standard scenario file is gone (like deletes and doesn't appear ingame anymore), because the scenario's that schould be in clean GTA V are gone and it doesn't stream the .ymt file that I put in the resource. I cannot find any change if I use data_file in fxmanifest.lua or not. The .ymt files are working correctly in GTA V Story mode.

blattersturm commented 3 years ago

'put a .ymt file in a resource' seems extremely vague. Are you able to be more specific and provide an actual repro (and ensure this isn't user error?)

FlavioMoretti commented 3 years ago

Sorry for the bad explaination. I've tested it a bit more and I have reproduction steps.

  1. Made a clean testserver downloaded from the artifacts.
  2. Put a downtown.ymt scenario file in my resources: stream/ folder.
  3. Edit the sp_manifest.ymt as explained here: https://forum.cfx.re/t/streaming-overriding-scenario-ymt/136666/27?u=deterministic_bubble
  4. When I specify it as data file in the fxmanifest.lua using SCENARIO_POINTS_OVERRIDE_FILE , the customized downtown.ymt is not working. And all the scenario's that are in the downtown.ymt stopped working.
blattersturm commented 3 years ago

Instead of these manual steps can you actually just provide your resource?

FlavioMoretti commented 3 years ago

streamresource.zip

FlavioMoretti commented 3 years ago

O wait, the resource above now works. But when the downtown.ymt is also declared in as a file in the fxmanifest.lua then every scenario in the resource stops working. So I guess it is working as intended, but maybe it's possible to stop ymt files from stopping to work when declared as file in the fxmanifest.lua.

blattersturm commented 3 years ago

'declared as a file' with what kind of path?

FlavioMoretti commented 3 years ago

When I put the 'code' below in my fxmanifest.lua the ymt's stop working. But when I only put the sp_manifest.ymt there it works. Even if I set the downtown.ymt as if it is in a path, but the path does not exists. It like overwrite the file with nothing and stops working.

files { 'sp_manifest.ymt', 'pillbox_hill.ymt', 'downtown.ymt', 'downtown_construction_site.ymt' }

blattersturm commented 3 years ago

Aha, that's probably rather another case of the file name sorting thing that's been going on for a very long time (which happens here as there's a downtown.ymt as well as a downtown_construction_site.ymt), at least that confirms this still occurs and needs figuring out.

Rather related to this breaking some internal binary search however and making the sp_manifest not exist. :P

blattersturm commented 3 years ago

Were you running the server on Windows or Linux?