search

citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.57k stars 2.12k forks source link

feat: key mapping support in RedM #1779

Open Z3rio opened 1 year ago

Z3rio commented 1 year ago

The native RegisterKeyMapping seems to exist both ingame and in the native list, although it does nothing at all upon being used. No errors at all happen or such, which is why I would believe it exists but isnt compatible with RedM.

I would guess it was directly copied from FiveM and therefore might not work with RedM. I tried to take a look at this myself, although I'm not that efficient in c++ etc.

Would greatly appreciate it if someone could take a look at this since its quite a dealbreaker.

Disquse commented 1 year ago

The native RegisterKeyMapping seems to exist both ingame

It doesn't exist in-game (in RedM).

in the native list,

And it's not in the natives list. You probably confused FiveM official reference and unofficial RedM reference.

Would greatly appreciate it if someone could take a look at this since its quite a dealbreaker.

For now this is a low-priority task.

Z3rio commented 1 year ago

Thank you for your response!

And it's not in the natives list. You probably confused FiveM official reference and unofficial RedM reference.

Yeah, I guess I might have done that then, do you perhaps have the link to RedM's native list? The main reason I thought it existed but just didnt work is because it doesnt error or such upon being used, which other natives / functions that dont exist would do.

For now this is a low-priority task.

Why? Dont you think it creates a lot of unneccesary resource usage to have a bunch of while loops checking it every millisecond instead? (I'm talking about stuff that has to be checked 24/7, not only at specific moments)

Disquse commented 1 year ago

Why? Dont you think it creates a lot of unneccesary resource usage to have a bunch of while loops checking it every millisecond instead? (I'm talking about stuff that has to be checked 24/7, not only at specific moments)

Because RedM developers are busy with more important stuff like fixing OneSync issues and crashes. Key mapping support is planned and might appear later this year. However, this is not an easy task, it would require to port a lot of code from FiveM and research the changes that were made by R* in RDR3 comparing to GTA5.

Yeah, I guess I might have done that then, do you perhaps have the link to RedM's native list?

There's no official list yet. You can check native declarations in citizen/scripting/* files. This probably going to be fixed soon.

Z3rio commented 1 year ago

Why? Dont you think it creates a lot of unneccesary resource usage to have a bunch of while loops checking it every millisecond instead? (I'm talking about stuff that has to be checked 24/7, not only at specific moments)

Because RedM developers are busy with more important stuff like fixing OneSync issues and crashes. Key mapping support is planned and might appear later this year. However, this is not an easy task, it would require to port a lot of code from FiveM and research the changes that were made by R* in RDR3 comparing to GTA5.

Yeah, I guess I might have done that then, do you perhaps have the link to RedM's native list?

There's no official list yet. You can check native declarations in citizen/scripting/* files. This probably going to be fixed soon.

I would love to help in any way that I can. Do you know if the Onesync issues are FiveM sided // C++ Or if they are in the actual lua resources being ran on RedM

Disquse commented 1 year ago

Do you know if the Onesync issues are FiveM sided // C++

No, this is about fixing OneSync issues on RedM. FiveM's OneSync works well.

Z3rio commented 1 year ago

Do you know if the Onesync issues are FiveM sided // C++

No, this is about fixing OneSync issues on RedM. FiveM's OneSync works well.

Ah my bad, I meant RedM mate. I'm just a sloppy typer haha. I meant if the issues with RedM's Onesync is in the actual src files // the files that are in this repo. Or if the issues are caused by other scripts misusing Onesync.