citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.49k stars 2.06k forks source link

GamePrimitives_MapData Crashes with TODO Reference QueueEvent #1932

Closed Legacy-TacticalGamingInteractive closed 7 months ago

Legacy-TacticalGamingInteractive commented 1 year ago

Lately we have been experiencing some client side crashes that the crash log has some pointers towards the following:

  1. https://sourcegraph.com/github.com/citizenfx/fivem/-/blob/code/components/extra-natives-five/src/GamePrimitives_MapData.cpp?L226

Which is:

// #TODO: use fast listener elision when we implement it
    fx::ResourceManager::GetCurrent()->GetComponent<fx::ResourceEventManagerComponent>()->QueueEvent2("mapDataLoaded", {}, (int32_t)mapData->name);
  1. https://sourcegraph.com/github.com/citizenfx/fivem/-/blob/code/components/gta-streaming-five/src/LoadStreamingFile.cpp?L3112

Which is:

    return g_origfwMapDataStore__FinishLoading(store, idx, data);

When does the crashing occur: This happens when driving to and from an area or flying, or no clipping from one area to another.

If you know a possible fix or if we should just wait it out until this is completed. Thank you.

AvarianKnight commented 1 year ago

This isn't the place for inactionable reports (i.e. no reproduction, no resource, etc) you should use the forums instead, you should also provide crash reports instead of snippets which have no crash data.

Legacy-TacticalGamingInteractive commented 1 year ago

What about the // #TODO: use fast listener elision when we implement it not yet being completed. This might help?

Apologies about not including a dmp on the initial post.

Here is one similar Crash dmp if it helps. CfxCrashDump_2023_04_08_15_22_39.zip

Its not related to a resource as far as I can see. Its anywhere on the map at any random time when doing those actions mentioned. Reproduction in this case is literally just playing the game driving/walking/flying or noclipping until it happens. Tedious, perhaps yes. Thats why I'm providing any dumps I can as I get them as nobody on the team has time to do that for every single report out there.

AvarianKnight commented 1 year ago

This is just an event trigger, the todo is likely just a part of an extremely long backlog.

This would be related to resources, most likely a map as thats the only thing that calls this

gottfriedleibniz commented 7 months ago

Believe this was also addressed in https://forum.cfx.re/t/lod-slod-texture-issues/5074672. Issues related to bad assets, archetype limits, etc. should be placed there.