search

citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.57k stars 2.11k forks source link

ReShade 5+ Message displayed when users have the latest version of ReShade installed to FiveM #2227

Open Jorban-MartysMods opened 1 year ago

Jorban-MartysMods commented 1 year ago

I am writing to address an issue regarding the message displayed when users have versions higher than 4.9.1 of ReShade installed. The current message is as follows:

If you want to force it to load anyway, add the following section to {Location of Citizen.fx file needing to be edited}:

   [Addons]
   ReShade5=ID:{ReShadeID} acknowledged that ReShade 5.x has a bug that will lead to game crashes
Note that no support is provided for this and that you should contact the author of ReShade for assistance.

We often do not ever recommend utilizing previous versions of ReShade (due to older versions/builds generally causing more issues for users in other games.) Additionally, versions 5.0 and above allow users to download and install separate builds that do not block depth buffer access in network-connected games. This specific Addon Support Build enables them to utilize depth effects and addons, such as: iMMERSE MXAO or CinematicDoF, and addons like NVE - which rely on the Add-on Support Build of ReShade to properly function.

The issue arises when users encounter difficulties understanding and following the steps provided in the error message. Despite our efforts to create comprehensive guides, users still struggle with this particular step. Therefore, I kindly request any information regarding the cause of these blocks being presented to the user. This information will be forwarded to Crosire or CeeJay.dk, allowing us to address the issue and guide users towards a version of ReShade that does not have this problem.

If it is not possible to remove this block, I would greatly appreciate a better understanding of the reasons behind it. Additionally, I am more than open to help theory craft a better solution for this issue above.

Thank you for your attention to this matter. I look forward to your response.

AvarianKnight commented 1 year ago

Looking at the commit ReShade 5.x was causing weird crashes.

There's a lot of people having 'NVIDIA GPU drivers' or 'd3d11.dll' crashes and these all seem correlated to having ReShade 5.x installed leading to some sort of corruption in a SetShaderResource call (due to passing bad parameters/some COM object lifetime issue?).

As such, we block it, but do leave an override if people are willing to experience game crashes.

Jorban-MartysMods commented 1 year ago

Yes - but I would like to know if this issue still exists, or if it has been fixed with the update over time to ReShade.

If not, I would like a better understanding/write up of the events so that I can pass them onto developers of ReShade.