citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.4k stars 1.99k forks source link

feat(data): Increased PoolSizes `ROPE` 12 -> 32 & `ropeData` 8 -> 24 #2603

Open JajarGaming opened 1 week ago

JajarGaming commented 1 week ago

Goal of this PR

When using ropes, we ran into some limitations and the poolSize might've been the cause. Also when using the SetRopesCreateNetworkWorldState native, we were receiving errors of the pool size being full. I couldn't find anything related to the CNetworkRopeWorldStateData pool and how it could be edited/increased, so thought it might be using the normal ROPE pool

How is this PR achieving the goal

A simple pool size increase in gameconfig.xml. RDR has a size of 48, GTA originally had a size of 12 and I bumped it up to 32.

This PR applies to the following area(s)

FiveM

Successfully tested on

N/A

Game builds: N/A

Platforms: Windows

Checklist

Wasn't able to compile - didn't have the environment setup for it, but this change shouldn't impact compilation anyways?

Legacy-TacticalGamingInteractive commented 1 week ago

<3

prikolium-cfx commented 4 days ago

Maybe it also worth to extend Rope definitions pool to allow adding of new rope types with custom texture and width? You can do it in same PR. Currently we are limited to 8 types, but I think nothing bad will happen if we extend it to 24

Legacy-TacticalGamingInteractive commented 4 days ago

Maybe it also worth to extend Rope definitions pool to allow adding of new rope types with custom texture and width? You can do it in same PR. Currently we are limited to 8 types, but I think nothing bad will happen if we extend it to 24

This would be awesome!

JajarGaming commented 4 days ago

Maybe it also worth to extend Rope definitions pool to allow adding of new rope types with custom texture and width? You can do it in same PR. Currently we are limited to 8 types, but I think nothing bad will happen if we extend it to 24

I'm not exactly sure where the definitions pool is located. It's my first time working with the fivem repo and C++.

prikolium-cfx commented 4 days ago

Maybe it also worth to extend Rope definitions pool to allow adding of new rope types with custom texture and width? You can do it in same PR. Currently we are limited to 8 types, but I think nothing bad will happen if we extend it to 24

I'm not exactly sure where the definitions pool is located. It's my first time working with the fivem repo and C++.

This pool is not mentioned in gameconfig because it's using default value (8). You need to add

<Item>
    <PoolName>ropeData</PoolName>
    <PoolSize value="24"/>
</Item>

To PoolSizes

JajarGaming commented 4 days ago

Will do