search

citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.49k stars 2.06k forks source link

Fivem crash windows sourcegraph link invalid #2735

Open Mathu-lmn opened 4 weeks ago

Mathu-lmn commented 4 weeks ago

What happened?

When crashing, we sometimes get the sourcegraph link to the fivem's code source. However this link comes invalid (code : https://github.com/citizenfx/fivem/blob/fbef73fff9f82341c86e959b2c2899d17af40e1f/code/client/launcher/Minidump.Symbolication.cpp#L76)

Example output by the crash window : https://sourcegraph.com/github.com/citizenfx/fivem/-/blob/master/fivem/code/components/extra-natives-five/src/WeatherNatives.cpp?L58= Working url : https://sourcegraph.com/github.com/citizenfx/fivem@master/-/blob/code/components/extra-natives-five/src/WeatherNatives.cpp?L58=

Expected result

A working url

Reproduction steps

  1. Crash
  2. Click the "blue" hyperlink
  3. See that the link is invalid

Importancy

Unknown

Area(s)

FiveM

Specific version(s)

Latest artifacts - Latest client

Additional information

No response

KillStr3aK commented 6 days ago

this should get more attention as its annoying but such an easy fix