tweak(vendor/range-v3): Merge with upstream - Githubissues

citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.

https://cfx.re/

3.52k stars 2.07k forks source link

tweak(vendor/range-v3): Merge with upstream #2837

Open tens0rfl0w opened 2 days ago

tens0rfl0w commented 2 days ago

Goal of this PR

MSVC (v14.41-17.11) stopped draggin-in 'std::basic_string' when referencing ''. This breaks building on any MSVC version >= v14.41-17.11

How is this PR achieving the goal

An upstream commit (https://github.com/ericniebler/range-v3/commit/3346e2bfa97c877a7a5ef8aeeaa7abe2dc16accf) fixed this by now including proper 'string' headers.

Related MSFT STL changeset: https://github.com/microsoft/STL/commit/cce32f411901e07d77a0eae5f2743c921e2b3a10

Upstream changes were tested and did not affect project usage.

This is a proper fix to the temporary fix included in: https://github.com/citizenfx/fivem/pull/2836

This PR applies to the following area(s)

Building

Successfully tested on

Game builds: Not applicable

Platforms: Windows, Linux, Github Actions

Checklist

[x] Code compiles and has been tested successfully.
[x] Code explains itself well and/or is documented.
[x] My commit message explains what the changes do and what they are for.
[x] No extra compilation warnings are added by these changes.

Fixes issues

/