search

citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.56k stars 2.1k forks source link

Jump list icon resizing is extremely low quality #801

Open blattersturm opened 3 years ago

blattersturm commented 3 years ago

While working on #794, some servers came back with these icons:

image

The on-disk icon files seem to be pre-resized to 16x16 via cfx-ui, but they're ugly at that.

blattersturm commented 3 years ago

https://github.com/citizenfx/fivem/blob/af97592752cd57d5fe6d231ad54630a009987100/ext/cfx-ui/src/app/game.service.ts#L731-L732

I wonder if 'high' is broken/changed, perhaps?

blattersturm commented 3 years ago

https://bugs.chromium.org/p/chromium/issues/detail?id=712844#c28

Yeah, that's a crbug which regressed since M89. Perhaps icon resizing should be done in host code anyway using WIC or such (and saving made asynchronous if it isn't already), as that may also be helpful if we ever need larger icons for #797.

blattersturm commented 3 years ago

WIC doesn't seem to support saving ICOs, but we can still use it to rescale and save PNGs and then prepend an ICO header to them for common sizes (16x16, 32x32, 48x48 and raw 96x96?)

IllInuz commented 3 years ago

After reading trough the topic mentioned on august 14th, wouldn't it be best to set the resizeQuality to 'Medium' refferencing post from within the article ;;

https://bugs.chromium.org/p/chromium/issues/detail?id=712844#c31

resizeQuality;; Low->Medium->High low_medium_high

Seems that resize to high quality jags out the image like how it was whilist being low quality resizes.