search

citizenfx / fivem

The source code for the Cfx.re modification frameworks, such as FiveM, RedM and LibertyM, as well as FXServer.
https://cfx.re/
3.58k stars 2.13k forks source link

Multiple people can join a server with the same steam account #978

Closed MatinHQ closed 3 years ago

MatinHQ commented 3 years ago

There is a bypass that you can use to join a server multiple times with the same steam account for example let's say we have Matthew, Andrew, and Davis they logged in to the same steam account

now there are two ways to bypass the system

they just count to three and click on the server at the same time and they are all in without any issue OR Considering the steam account name is test1, Matthew join the server with that name then Andrew goes into the steam profile setting and changes the account name, it doesn't sync with others but he will be able to join the server with that new name, meanwhile, Matthew is still connected to that server!

blattersturm commented 3 years ago

Not a bug, nor in any way something that should be an issue on our end. If your server scripts don't take multiple people with the same identifier well, check for it in your server scripts.

Not sure how names are related either, there's no name checking at all either, so.. what?

blattersturm commented 3 years ago

In fact, how is this 'a bypass' when there's not even any logic checking for dupes to bypass in the first place?!

Did you mean to report this on the repo for some server script you're using?

MatinHQ commented 3 years ago

I checked at my end and I did fix this problem for my own server, but if it's not really a problem at your end why FiveM automatically rejects connection when the account is already connected to that server, what I described above is what can bypass that check so I don't care if you don't want to fix it but it almost works at 80% of servers and people can duplicate too many stuff

blattersturm commented 3 years ago

why FiveM automatically rejects connection when the account is already connected to that server

It doesn't, though. There's no such 'check'.

what I described above is what can bypass that check so I don't care if you don't want to fix it

If there's no such check, how can we even fix it if we'd 'want to'?

and people can duplicate too many stuff

Sounds like.. bad scripts? There's no check to 'reject connection when the account is already connected', so there's nothing being bypassed here.

blattersturm commented 3 years ago

What is the message you're even getting when your connection is 'rejected' for already being connected?