social media links - Githubissues

citizenlabsgr / website

Citizen Labs' website.

https://citizenlabs.org

MIT License

5 stars 5 forks source link

social media links #56

Closed Allen616 closed 4 years ago

Allen616 commented 4 years ago

Correct so that social media logos appear in footer.

Allen616 commented 4 years ago

The original theme used an older version of FontAwesome which did not include logos like meetup and GitHub, something we would like to include. While trying to update, I instead created an issue so that none of the logos now appear.

FontAwesome, upgrading from Version 4

Allen616 commented 4 years ago

The following places are where I am trying to troubleshoot:

static/css/icons.css
layouts/partials/footer.html

config.yaml is the file that social media links and icons are provided for the site build.

diiq commented 4 years ago

Commit https://github.com/citizenlabsgr/website/commit/60a10191abc0e281cf215d6871b35bcded9a909f should fix this issue. @Allen616 your instincts were good, I added fab and also an fa- prefix to the class of each of the icons, and that seems to have done the trick.

Allen616 commented 4 years ago

Great, thanks.

jacebrowning commented 4 years ago

Seems to be working:

Allen616 commented 4 years ago

Does the css still need to be fixed (compiled??). I pushed the changes, but the site doesn’t look good on my iPad or phone. I don’t know how to do that. @diiq