citizenmatt / resharper-clippy

Clippy. For ReSharper
MIT License
221 stars 11 forks source link

Ability to change agents #2

Open alexangas opened 10 years ago

alexangas commented 10 years ago

Could you please add a feature so that we can change agents from Clippy to others, e.g. the cat?

citizenmatt commented 10 years ago

Thanks for the request, but I don't really have any plans to maintain this extension - it was intended as an April Fools' joke and I'm very surprised to actually see it being used and certainly wasn't expecting feature requests! That said, I'm open to being persuaded for new features - pull requests certainly help!

However, this feature has implications with things such as package size - all agents would need to be in the package to be able to show a chooser (and I think the DoubleAgent library I'm using supports a chooser) and show images of the agents.

But you should be able to add it yourself, by replacing the clippit.acs file with a renamed links.acs file.

alexangas commented 10 years ago

I guess seeing Clippy again brought back some fond memories leading me to write this request... although I have to say after a few hours of running the extension they weren't so fond and I was reminded why Clippy was sent to the dustbin!

Thanks for the trick on changing agents, I may try that out. Oh and thanks for the extension, it was an awesome April Fool's!

sheitmann commented 10 years ago

I will add an options page where you can select the active agent. By default you will only have clippy available as it is packaged with the plugin. You can add other agents and they will be stored in some appdata folder. If possible I try to add some preview for the agent so you see what agent is behind the file.

What do you think?

alexangas commented 10 years ago

That sounds super!

citizenmatt commented 10 years ago

Nice idea - leave Clippy in the package, and allow choosing from a known folder. I don't know how the DoubleAgent character chooser works - I suspect it will look at files in the character folder, but it should allow for previewing the character file.