citizennet / purescript-ocelot

An opinionated component library for Halogen apps
https://citizennet.github.io/purescript-ocelot/
Apache License 2.0
101 stars 15 forks source link

FBCM-5217 [Bugfix] Disabled Typeahead Still Allows Changing Selection #256

Closed boygao1992 closed 1 year ago

boygao1992 commented 1 year ago

What does this pull request do?

Before, when a single-value Typeahead is disabled, one can still change the selection by clicking on Change button to open the item container and then make a selection there. Fixed by not registering ToggleClick action on the Change button (a span styled as a button which doesn't support disabled prop) when the Typeahead is disabled.

How should this be manually tested?

boygao1992 commented 1 year ago

Thanks for the review!