search

citizennet / purescript-ocelot

An opinionated component library for Halogen apps
https://citizennet.github.io/purescript-ocelot/
Apache License 2.0
101 stars 15 forks source link

API-3656 Replace Gotham fonts #261

Closed davezuch closed 10 months ago

davezuch commented 10 months ago

What does this pull request do?

We are losing our license for Gotham fonts soon, so we replace them with an open source lookalike, Metropolis.

How should this be manually tested?

citizengabe commented 10 months ago

@davezuch I'm having trouble building this project using either Node versions 18 or 20. What version are you on?

citizengabe commented 10 months ago

I was able to get around the webpack error I was seeing on node v18 by using a workaround, but it caused an error in parcel which required me to unset the env var.

I think we need to investigate not using an old version of webpack and getting this project working on the latest version of node.

davezuch commented 10 months ago

@citizengabe yeah I had to use Node 14 to get the build working. Node 14 is past EOL so in order to install it with Nix I had to run:

NIXPKGS_ALLOW_INSECURE=1 nix-shell -p nodejs_14 -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/nixos-23.05.tar.gz

I think we need to investigate not using an old version of webpack and getting this project working on the latest version of node.

Yeah I wondered if we should spend time solving this instead of working around it. My feeling is that this repo is basically in maintenance mode and we won't be working with it much more, so it's not worth it. If you feel otherwise though, I'm not opposed to it being addressed.

davezuch commented 10 months ago

@citizengabe I pushed up one more minor change if you don't mind looking it over as well fbecd2b.

citizengabe commented 10 months ago

@citizengabe I pushed up one more minor change if you don't mind looking it over as well fbecd2b.

Looks good

davezuch commented 10 months ago

Thanks for the review!

citizengabe commented 10 months ago

@citizengabe yeah I had to use Node 14 to get the build working. Node 14 is past EOL so in order to install it with Nix I had to run:

NIXPKGS_ALLOW_INSECURE=1 nix-shell -p nodejs_14 -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/nixos-23.05.tar.gz

I think we need to investigate not using an old version of webpack and getting this project working on the latest version of node.

Yeah I wondered if we should spend time solving this instead of working around it. My feeling is that this repo is basically in maintenance mode and we won't be working with it much more, so it's not worth it. If you feel otherwise though, I'm not opposed to it being addressed.

I'm fine not updating as long as I can use it as a library without issue.