search

citizenos / citizenos-fe

6 stars 3 forks source link

Topic: Manage co-creators box shows all participants #1010

Open BeccaMelhuish opened 8 months ago

BeccaMelhuish commented 8 months ago

Something needing review by @kevincrepin at some point, this manage co-creators box currently shows all participants (not just admins and editors). Should it? And what happens when there are say 50 or 100, currently looks like it will be one very long list down the side of the edit flow :)

image

BeccaMelhuish commented 8 months ago

Will link to this issue for @kevincrepin's reference when reviewing, as is connected :)

ilmartyrk commented 8 months ago

@BeccaMelhuish I removed the users with participant permissions from the co-editors list. Though it will probably need API side update to exclude them from results and this way possibly add pagination for long list of editors

BeccaMelhuish commented 8 months ago

Ok yes, though I do think this bit needs some review from @kevincrepin still anyway - to check the UX is right, don't want to rush to make changes that don't make sense for the users' journey(s) :)

ilmartyrk commented 2 months ago

Add a filter to get only users that have edit or higher permissions level, add scrollbar/pagination if the list gets too long

kevincrepin commented 2 months ago

I agree that it probably shouldn't scale into infinitum, but let's also not add a scrollbar into this. I suggest we do the good old "+ x more" which would open up the popup form where to manage:

Property 1=Variant4

@ilmartyrk you can find this component variant here: https://www.figma.com/design/gOJ4i00538e0qaP6IKIPVE/Platform-2.0---Design?node-id=137-28657&t=3hHy3U6W9ohEF2Lu-1