citizenos / citizenos-fe

5 stars 3 forks source link

GROUP/TOPIC: Incorrect and misleading text in Topic->Add Topic to Group #1211

Closed ssin1901 closed 1 month ago

ssin1901 commented 5 months ago

What is the problem? @ilmartyrk @BeccaMelhuish almost flagged this is as an important permissions related bug due to misleading text.

If a user has Member only permissions for a Public group then they cannot Add Topic to Group from Settings. The text indicates that simple Joining a Group will allow them to add the topic to the group (screenshot1).

Screenshot 2024-05-17 at 17 19 36

However, that applies only to Private Groups.

Why is this a problem? Really confusing for the users

Possible solution. Can we add the word "Private" to this view?

BeccaMelhuish commented 2 months ago

Hi @ssin1901 so sorry I lost track of this one, coming back to it now!

Here's what I suggest we do to solve this, the (i) being a help tooltip, in which the italic (i) text would be shown. (The reason for suggesting it as a tooltip is that it gets a bit overwhelming to have too much info and in the main text, and it'll only be important for some users, who can then choose to open it).

Wdyt? :)

Add to group You can add this topic to a group you're part of, either now or later. All topics in a group are shared with its members, and can be shared via the group's public link too. To add topics to a group, you'll need to have the correct rights (i)

(i) In a private group, anyone can add topics. In a public group, only admins can add topics, but anyone can 'Request to add topics' via the button on the group's page.

No groups to add yet Once you're part of a group and have the correct rights, you can add this topic to it here. Don’t worry, you can skip this now and still do it later.

BeccaMelhuish commented 2 months ago

@ssin1901 I figured you'd be OK with the text changes so have made them myself in the strings (ideation strings though, so not yet live), so then it's just for @ilmartyrk to add the tooltip :)

@ilmartyrk the tooltip placement would be here (though the text is now different):

image

And the tooltip text should be:

Who can add topics In a private group, anyone can add topics. In a public group, only admins can add topics, but anyone can 'Request to add topics' via the button on the group's page.

ilmartyrk commented 1 month ago

@BeccaMelhuish tooltip should probably have been a separate issue :)

ssin1901 commented 1 month ago

@ilmartyrk @BeccaMelhuish for the tooltip, I should test the test app right?

BeccaMelhuish commented 1 month ago

I checked both and don't see it yet :)

BeccaMelhuish commented 1 month ago

Checked again today in a few different views in test and it is indeed there, so moving to done :)

ssin1901 commented 1 month ago

Tooltip present (screenshot1) so moving to Done.

Screenshot 2024-09-24 at 01 55 51