citizenos / citizenos-fe

5 stars 2 forks source link

IDEATION: Unclear error message when ideation is closed #1293

Closed BeccaMelhuish closed 2 months ago

BeccaMelhuish commented 3 months ago

When a user tries to click the lightbulb in an ideation that is closed, they get an error message "Insufficient permissions" which isn't really correct and wouldn't mean much to them anyway.

Can the error message in this case (and any other cases where trying to do something in a closed ideation brings up this message) be: "This action is no longer possible, as the ideation has closed."

image

And generally I'm thinking we should avoid the "Insufficient permissions" error message, as it won't help users very much in most situations - will be better to tell them what the actual problem is in a way that's relevant to them. So @ilmartyrk if there are other cases of this error message being used I'd be happy to provide suitable copy to replace them :)

ilmartyrk commented 3 months ago

@BeccaMelhuish it is the default error from server for when we don't have any specific definition in place. But I guess just disabling the button would work in this case

BeccaMelhuish commented 3 months ago

@ilmartyrk it is already disabled (though no visual difference, it just doesn't work) but I think it's good to have the message telling people why..

I guess we do have this though, so may be fine: image

How about if the buttons are greyed out a bit? Not sure how this would look though..

Maybe @kevincrepin can suggest the best UX for it :)

ilmartyrk commented 3 months ago

@BeccaMelhuish this error was from server because the button was not disabled, it changes the on/off position based on if the vote went through or not. I posted a fix with actually disabling the button and graying it out as we do in other places

BeccaMelhuish commented 3 months ago

Ah nice, adding a screenshot in case Kevin wants to check, but this seems a good solution :)

image

kevincrepin commented 3 months ago

Since the look of this might change...Based on other sieesu/conversations. We can still use the disabling tho: the 50% transparency. Screenshot 2024-06-07 at 15 12 19

In figma: https://www.figma.com/design/gOJ4i00538e0qaP6IKIPVE/Platform-2.0---Design?node-id=13338-115399&t=xoQN4LtSq20tl0HZ-1

ssin1901 commented 3 months ago

@ilmartyrk @BeccaMelhuish moving this to in progress as currently the fix has not been implemented.