DISCUSSION: Discussion deadline / discussion closing inconsistencies

citizenos / citizenos-fe

4 stars 2 forks source link

DISCUSSION: Discussion deadline / discussion closing inconsistencies #1319

Open BeccaMelhuish opened 1 week ago

BeccaMelhuish commented 1 week ago

@kevincrepin @ilmartyrk

Currently we have a bit of an inconsistency in that we say this:

But then in reality, nothing changes after the deadline, I tested and could still post:

We also have an option to 'Close discussion', which then makes the deadline the minute that you closed it. But again otherwise doesn't change anything - still possible to post.

I suggest that we do two 'quick fixes' for the tests which are:

Just so that the text matches reality for the tests, I'll change the text by the discussion deadline to this for now:

You can opt to include a deadline, to let participants know by when they should submit their contributions. You can always edit the deadline at any time.

@ilmartyrk is it easy to just remove the possibility to 'Close discussion', so it's no longer in that menu?

Then when we have more time (and hopefully some insights from the testing), we can think more deeply about what to do about this :)

BeccaMelhuish commented 1 week ago

I also found this misleading text, so will change it to:

"The deadline indicates to participants by when they should contribute."

ilmartyrk commented 1 week ago

@BeccaMelhuish I will fix it on the API side so that if deadline is reached users cannot add any arguments. I also thought about making it so in the future that if there is a deadline set discussion will end, but if there are no deadlines set for discussion or ideation it will stay open even if topic is in another phase

BeccaMelhuish commented 1 week ago

Ah OK cool, will switch the texts back then :)

And that sounds good for the future possibility of having more than one phases at once! (Once all worked out by Kevin of course, when we come to it) :)

ilmartyrk commented 1 week ago

@BeccaMelhuish posted a fix

BeccaMelhuish commented 1 week ago

Great!

Just needs a couple more clues that it's ended:

Shall we grey out the reply buttons too? Currently you can type a reply, but only find out after you try to post that it is 'Forbidden!'

Can we have the same box as we have for ideation and voting having ended?

With text:

The discussion has ended! The discussion has been closed. You can no longer add arguments or replies, but you can still read and react to them.

I'm not sure what we do with this though, what do you think @kevincrepin? As the No. of contributions is still important.. This part's not urgent before the testing though I don't think.

ilmartyrk commented 1 week ago

@BeccaMelhuish added the info box and disabled the buttons

BeccaMelhuish commented 1 week ago

@ilmartyrk grand, thank you! Though the text seems to be the ideation one, could it be switched to this below? (Not sure I can be certain of which line to edit in the strings)

The discussion has ended! The discussion has been closed. You can no longer add arguments or replies, but you can still read and react to them.

ilmartyrk commented 1 week ago

@BeccaMelhuish posted a fix

ssin1901 commented 5 days ago

@ilmartyrk @BeccaMelhuish seems fixed to me (see screenshot) but was it agreed that replies are also disabled, if the Discussion is closed?