citizenos / citizenos-fe

5 stars 2 forks source link

GROUPS: Enable removal of topics from a group (quick fix first, then big fix) #1529

Open BeccaMelhuish opened 2 weeks ago

BeccaMelhuish commented 2 weeks ago

A spin-off issue from this now closed issue. As discussed, we need to provide a way for group admins to remove topic from a group

Copying the conversation over to here:

From @kevincrepin:

Was thinking about this missed functionality of removing topics from groups and maybe this could be a solution. https://www.figma.com/proto/gOJ4i00538e0qaP6IKIPVE/Platform-2.0-UI?page-id=3094%3A111670&type=design&node-id=12468-106573&viewport=-15119%2C-16136%2C0.5&t=4Ly7iTmY3x9xE8m8-1&scaling=scale-down&starting-point-node-id=12468%3A106573&show-proto-sidebar=1&mode=design

We have a button "manage topics" next to the add/create topic which allows the admin to remove all topics in one go or go into a sort of "edit mode" which will reveal a remove button per topic. I mainly didn't want to have a repeating remove button on each topic, but if this idea is too vague or does not make sense then I think that would probably be the next suggestion. My concern is that it might be very clear how to get out of this "edit mode" again...

However this idea does come with an opportunity to do it similarly for members: you can click on the Members tab to see the update. So instead of the bulk actions in the bottom left as we have it now, there would also be a "manage members" option here which would open the same menu as we have now for the bulk actions. But it would be consistent with the management of the topics then.

image

image

From @ilmartyrk:

@kevincrepin I like the solution, though my concern is that with 2 buttons side by side we need another design at around 600px screen width. As currently there isn't enough space there for 2 buttons

BeccaMelhuish commented 2 weeks ago

@kevincrepin Some thoughts from me on this:

It did take me a bit of time to try to guess what 'Enable select to remove' meant, but once I'd clicked on it, was pretty clear.

Re the problem of how to get out of this mode, my instinct was to click elsewhere in the topic to revert back to 'normal' mode, which I guess should be quite intuitive for most users? I think with the combination of this option and the menu it should be OK.

I wonder if a little 'Cancel' under each might also help? image

I'd probably want to user test this in the 'test' environment before it went live though - to make sure people understand it, and also that the added menu doesn't cause any other areas of confusion.

As a quick fix (as we have no testing rounds planned currently), I'm wondering if we could just add 'Remove from group' as an additional item in the manage topic menu, which only appears when the topic is part of at least one group? And then a pop-up that lets them select which one.

image

BeccaMelhuish commented 2 weeks ago

I've add the 'UX test pre-live' button, but that's only for the 'Manage' topics button. For the quick fix 'Remove from group' in the menu we could make it live already.