citizenos / citizenos-fe

5 stars 2 forks source link

Discussion: Closed discussion has an add argument button #1590

Open ssin1901 opened 1 week ago

ssin1901 commented 1 week ago

What is the problem? Tested in Google Chrome in incognito mode

When a discussion closed and there are no discussions, this is the view (screen recording). The button looks and functions as a button but does nothing.

https://github.com/user-attachments/assets/936d597f-3bd6-45b9-8160-a405b85c348f

Why is this a problem? Confusing UX

Possible solution. @BeccaMelhuish did we discuss this at any point?

BeccaMelhuish commented 1 week ago

Good catch @ssin1901 thank you! I guess hopefully it wouldn't happen often, but we do need some new texts for if it does.

Will tag @kevincrepin for input, but I'd suggest this:

image

I feel it might also be good to indicate that the reason they can't see the arguments is because there were none added, not because we've hidden it now it's closed.

But I'm not sure how to do that smoothly ('Discussion ended, no contributions' could be the heading, but not sure that works well, and adding a replacement last line could work but takes a lot of reading). Maybe just this is enough, 0 contributions:

image

BeccaMelhuish commented 6 days ago

@ilmartyrk @ssin1901 seems like a 'small' and 'soon' one to me, so I labelled and moved as such

kevincrepin commented 4 days ago

We actually had a state for that :)

Screenshot 2024-09-27 at 15 30 35

I don't think that button should be there at all anymore, not just disabled.