Open BeccaMelhuish opened 2 weeks ago
There's also the additional section under the settings where we show the groups. So if I create a topic from within a group it automatically shows that group here. But I can also still remove the group :) At which point the Private/Public option also becomes again fully available, because this topic is effectively not belonging to any group right now.
That also made me think that I can also add this topic to multiple groups from here, which could be public or private. How does this now affect the public/private option? I think we completely overlooked this.
Of course we can also tweak this part so the user cannot remove the group or add any other groups. This would be the simplest way. But if you would also want to add this topic to other groups then it would make more sense to create the topic from the "baseline" create action.
And oh yes, I agree only the Private box should be disabled, not the entire section.
Very good points, this is much more complex than I'd realised! Assigning myself to give it some deeper thought soon :)
What is the problem? In this issue, we came up with a solution which meant that when an admin creates a new topic within a group, it would be default 'public' and wouldn't be possible to set it as private in the 'create' flow. (Only in the 'edit' flow, as we couldn't prevent it there, I understood).
However, as per @ssin1901's screen recording here, it's not currently happening. When users create a new public topic within a group, it is created with private selected by default and nothing greyed out/locked. So they can still select public, but it's not locked to public.
Why is this a problem? This means users can still create private topics in public groups, and may also cause confusion as to what 'public' means within a private group, as seen in user tests. (I.e. does it mean the general public, or just all the people in the group).
Possible solution. Should be implemented as per the solution agreed in #865 with 'public' pre-set by default and locked.
Though I would suggest for clearer UX (and accessibility, as the grey text is hard to read) that rather than greying out the whole block, the 'Visibility' heading and explanation and the 'public' box should be displayed as per standard, but just the private box should be greyed out. @kevincrepin, Lydia, @TiinaDUX could give their view on that though :)