search

citizenos / ep_embedded_hyperlinks2

Etherpad plugin to embed hyperlinks within a pad
5 stars 8 forks source link

[Bug] Copy/cut+paste corrupts embedded hyperlinks #7

Open Oremountainflorian opened 4 years ago

Oremountainflorian commented 4 years ago

Hey, this plugin could be super useful for the collaborative work in pads, but it still comes along with some problems... Copying/cutting links still destroys them which compromises the editing somethow :/

System

OS: Win 8.1 and 10 Browser: Firefox 76 / Chrome 81 / Microsoft Edge Version 81.0.416.72 Etherpad Version: 1.8.4

Example / Steps to reproduce

Embed a hyperlink (e.g. https://tuuwi.de) to the an arbitrary word (here "tuuwi").

In general, the behaviour equals for Copy (Ctrl+C/right click) and Cut (Ctrl+X/right click) and applies in the same way for copying within the same pad as well as from one pad to another (in the same browser).

Firefox

Authorship color not cleared

The pasted embedded hyperlink still appears as link but becomes unclickable (nothing happens on click). Copying this again with authorship color cleared opens in http://www.url-,.com/

Authorship color cleared

The pasted embedded hyperlink opens in http://www.url-https.com//tuuwi.de,https://tuuwi.de and not in https://tuuwi.de as expected.

Behaviour resambles when copying from firefox to chrome/edge.

Chrome and Microsoft Edge

The embedded hyperlink is pasted as plain text (independently whether authorship color is cleared or not). Behaviour resambles when copying from chrome/Edge to firefox.

Would be really cool if that was fixed! :) Thank you very much for your commitment!

techware01 commented 4 years ago

In Safari on MacOS for both ways (autohorship cleared or not cleared) the link gets destroyed when copying it.

webzwo0i commented 2 years ago

@Oremountainflorian @techware01 Can you test if https://github.com/seballot/ep_embedded_hyperlinks2/pull/23 solves the problem for you?