search

citizenos / ep_image_upload

Add images to etherpad and upload them to Amazon S3
Other
9 stars 16 forks source link

Image resize like done on ep_copy_paste_images #10

Open Oremountainflorian opened 4 years ago

Oremountainflorian commented 4 years ago

Hey out there,

have you already considered providing the option to resize images as @JohnMcLear did on ep_copy_paste_images?

Here are some infos about that

https://github.com/JohnMcLear/ep_previewimages/issues/14#issuecomment-94252258

Thank you very much for your engagement! Best wishes, Flo

Oremountainflorian commented 4 years ago

Update On Firefox/Chrome (at least with Windows) it's possible to resize images by going to the respective line hitting tab (smaller) and shift+tab (larger)

tiblu commented 4 years ago

Yes, we have talked about it, but our organization has 1.5 developers thus it will probably be at the bottom of the priority list.

I will add this to our prioritization.

Also, we welcome pull requests!

loorm commented 4 years ago

Triage 23. @Oremountainflorian ep_copy_paste_images implementation is styles-only. However, in Citizen OS, we must also be able to generate document files (docx) from EP content. Even if we enabled image resize in EP, the image would still appear full size in docx, thus creating an inconsistent user experience.

The scope of making this change will become very large very quickly for us. Like @tiblu said, we very much welcome pull requests, but it will be an undefined while, before we ourselves get around to implementing image resize. Unless a large number of users start reporting this as an inconvenience.

KatiVellak commented 3 years ago

Legally reviewed, no additions.

loorm commented 3 years ago

@tiblu @ilmartyrk Any changes in the new EP version regarding image resize?

ghost commented 2 years ago

Any update regarding image resizing , the old version it took full width of page but now it takes only 1/4 of the page :

old version of plugin better preview: image

the new version: image

I preferer the old version

loorm commented 2 years ago

Tagging @anettlinno. Please see most recent community input above.

anettlinno commented 2 years ago

Triage 52. Currently the maximum height of the picture is set on 500 pixels. We will take off the height limit and this should fix this problem. Est. dev. time 30 min. Sending to development.

The limit is set inside ace.css and it comes from etherpad core styles. We can add the style update inside plugin stylesheet to override this limit

ilmartyrk commented 2 years ago

Removed the height limit from styles, but this initial issue still remains adding resize functionality to images

anettlinno commented 2 years ago

Triage 60. Sending this issue back to In Prep to wait for the decision if we will continue using EP or we change to some other text editor platform. This decision is waiting behind the redesign project.