search

citizenos / ep_image_upload

Add images to etherpad and upload them to Amazon S3
Other
9 stars 16 forks source link

The toolbar icon is not shown properly #12

Closed c0dev0id closed 3 years ago

c0dev0id commented 4 years ago

The upload icon does not show up properly in the toolbar. Tested in Chrome and Firefox on Windows.

image

echristiaans commented 4 years ago

I second this, have the same problem. Tested on MacOS with Firefox and Chrome.

c0dev0id commented 4 years ago

I've replaced it with 📤 in my installation. Maybe 📂 would be better? I looked througth the emojis that are available in most fonts. Or maybe 📷?

Ideal would be a picture in a frame as we know it from the other WYSIWYG editors.

EDIT: Ah, there it is: 🖼

echristiaans commented 4 years ago

Out of interest, how did you replace it? which file(s) did you change?

tiblu commented 4 years ago

@c0dev0id Thanks for the report! What version of Etherpad are you using? We have not jet upgraded to latest (1.8.3) thus have not tested on it.

Related issues:

c0dev0id commented 4 years ago

@tiblu I'm using the latest etherpad (master branch). However, the icon has nothing to do with the etherpad version.

@echristiaans Just replace the content here: https://github.com/citizenos/ep_image_upload/blob/master/templates/editBarButtons.ejs#L3

echristiaans commented 4 years ago

thanks, that worked for me.

Vinc89 commented 4 years ago

Hello, I have the same issue. Could you please advise what exactly needs to be changed in the editBarButtons.ejs? Thanks

echristiaans commented 4 years ago

assuming you have installed Etherpad in /opt/etherpad, edit the file /opt/etherpad/node_modules/ep_image_upload/templates/editBarButtons.ejs.

<style>
  button.buttonicon.ep_image_upload.image_upload:before {
    content:"\E83A";
  }
</style>

What you need to change is the code E83A to something of your choosing. Keep in mind though, by default you can only choose what is defined in src/static/font/config.json - convert the code to hex, that's the number you need to configure. If you want another icon, you first need to add it to config.json.

rasos commented 3 years ago

E83A shows a nice picture icon, so this seems already perfect.

woeterman94 commented 3 years ago

Same issue here. Should I make a pull request?

tiblu commented 3 years ago

Same issue here. Should I make a pull request?

Sure, PR would be nice! I'm currently not actively developing EP, but @ilmartyrk MAY have time to review and help as needed.

JohnMcLear commented 3 years ago

This should be fine in develop. I think the issue was due to a missing icon in EP fontawesome?

JohnMcLear commented 3 years ago

https://github.com/citizenos/ep_image_upload/pull/28