citizenos / ep_image_upload

Add images to etherpad and upload them to Amazon S3
Other
9 stars 16 forks source link

Preview URL pasted image which was not uploaded #32

Open rasos opened 3 years ago

rasos commented 3 years ago

We have been promoting not always uploading images but also just to paste an image URL. This saves disc space and is the preferred method if copyrights are not cleared.

However, the ep_previewimage plugin is not intended to be used with ep_image_upload anymore https://github.com/JohnMcLear/ep_previewimages/blob/master/README.md

So is it intended that the function will be integrated in ep_image_upload, showing images for which we only have an external image URl in the pad? Currently, no image is shown, if I add an image URl into the pad.

JohnMcLear commented 3 years ago

This would be very easy for someone to hack into this plugin.

It would just require Dom line processing and some test coverage.