search

citizenos / ep_image_upload

Add images to etherpad and upload them to Amazon S3
Other
9 stars 16 forks source link

Line numbering is broken -- Testing in Azure #35

Closed alexeisenhart closed 3 years ago

alexeisenhart commented 3 years ago

Hello! I love this plugin, by the way.

I just got Etherpad set up and running in Azure. I mention this becausetThere were a number of issues that had to be addressed in Etherpad-Lite to support Azure, so the hosting environment might introduce some issues for the plugin as well.

Image uploading via copy/paste, drag/drop and the upload button seem to be working fine. But the line number spacing gets weird.

In this image, I added a CSS rule via the Developer Tools console to resize the images to 25%. You can see that the line numbers resize reasonably.

image

However, when I remove my CSS change, the spacing between the line numbers increases, but it seems to grow independent of the document context frame, and now I can't scroll down to view the rest of the document.

image

There are no client or server side errors.

If I disable line numbers then the extra space at the bottom goes away, but I can't scroll down to see the rest of the document.

image

I can scroll with the cursor, but there are no scroll bars. I added a bunch of text at the top of the document (to push the images off screen) and this did not cause scrollbars to appear.

Please let me know if there's any additional information that I could provide!

alexeisenhart commented 3 years ago

I uninstalled the plugin and tried with just text, but I get the same error. This might be an Etherpad bug rather than this plugin.

The scrollbar scrolls the page down (to show more line numbers) rather than the document.

image

rhansen commented 3 years ago

Possibly caused by a bug in this change: https://github.com/ether/etherpad-lite/pull/4831. Mind opening a new bug in the ether/etherpad-lite repo?

JohnMcLear commented 3 years ago

Yea I think this is a core issue, will look into it.

JohnMcLear commented 3 years ago

@seballot do you think you have time to look into this? I can't checkout my branch to see if the code came from me or not because we closed it in favor of yours.

rhansen commented 3 years ago

Opened a bug in Etherpad core: https://github.com/ether/etherpad-lite/issues/4914

Feel free to close this one.

alexeisenhart commented 3 years ago

Closing this issue because it looks like a base Etherpad-lite changeset introduced the issue unintentionally.