search

citizenos / ep_image_upload

Add images to etherpad and upload them to Amazon S3
Other
9 stars 16 forks source link

BUG: Support to configure upload image button (addImage) in toolbar has been lost #38

Open tiblu opened 3 years ago

tiblu commented 3 years ago

Reproduce

This USED TO BE a valid configuration:

"toolbar": {
    "left": [
      ....
      [
        "fontColor",
        "addFootNote",
        "addImage"
      ]
    ],

But, as toolbar action addImage has been lost, this throws an error when toolbar is loaded:

TypeError: /home/m/dev/etherpad-lite-heroku/etherpad-lite/node_modules/ep_etherpad-lite/templates/pad.html:70
    68|       <ul class="menu_left" role="toolbar">
    69|           <% e.begin_block("editbarMenuLeft"); %>
 >> 70|           <%- toolbar.menu(settings.toolbar.left, isReadOnly, 'left', 'pad') %>
    71|           <% e.end_block(); %>
    72|       </ul>
    73|       <ul class="menu_right" role="toolbar">

Cannot create property 'grouping' on boolean 'false'
    at ButtonsGroup.render (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node/utils/toolbar.js:65:35)
    at _.map (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node/utils/toolbar.js:272:76)
    at Function.map (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/underscore/underscore.js:1329:24)
    at Object.menu (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node/utils/toolbar.js:272:22)
    at eval (eval at compile (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/ejs/lib/ejs.js:662:12), <anonymous>:69:25)
    at pad (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/ejs/lib/ejs.js:692:17)
    at Object.exports.require (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node/eejs/index.js:94:15)
    at args.app.get (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node/hooks/express/specialpages.js:57:19)
    at Layer.handle [as handle_request] (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/layer.js:95:5)
    at /home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/index.js:281:22
    at param (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/index.js:354:14)
    at paramCallback (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node_modules/express/lib/router/index.js:401:21)
    at args.app.param (/home/m/dev/etherpad-lite-heroku/etherpad-lite/src/node/hooks/express/padurlsanitize.js:18:7)

Cause