search

citizensadvice / cads

Citizens Advice Design system
https://citizensadvice.github.io/cads/
8 stars 0 forks source link

updated buttons doc #145

Closed adam-parsons-ca closed 5 years ago

adam-parsons-ca commented 5 years ago

Updated the docs as per agreed changes. How the code is shown may need to be reviewed as the they are getting a little long with the inline svgs.

btomy commented 5 years ago

@ChrisBrettCA Buttons documentation looks all good, don't forget to update the button container as well with the current button markup

adam-parsons-ca commented 5 years ago

Perhaps what we could do is for the example showing the code... we could just put <svg>[your svg code here...]</svg>, which could make it a little clearer in the examples shown?

@ChrisBrettCA I think these snippets could be a way of people copying code into their project. ie if they want the print button they could just copy the markup for that button. What do you think?

adam-parsons-ca commented 5 years ago

@btomy good point. I have updated it in the latest commit