citp / BlockSci

A high-performance tool for blockchain science and exploration
https://citp.github.io/BlockSci/
GNU General Public License v3.0
1.34k stars 259 forks source link

fix: inconsistent txFirstSpend #385

Closed maltemoeser closed 4 years ago

maltemoeser commented 4 years ago

Fixes a rare situation where, due to the parallel processing of transactions, it can happen that an input script is serialized as a wrapped script in a later transaction before it is serialized as a normal input script in a previous transaction. This is a simpler fix than moving the input processing of wrapped scripts to the last stage of the processing pipeline.

I'll double-check this with the new integrity check tool one more time before merging.

(shouldn't have #383, but made it easier for now to create the PR)

maltemoeser commented 4 years ago

Parsing integrity comparison: https://gist.github.com/maltemoeser/fa67ab38647cf3df5285e56a666889c1

maltemoeser commented 4 years ago

Rebased on top of v0.6