citp / ad-blocking

Prototypes of ad blocking techniques proposed in the "Future of Ad Blocking" paper
MIT License
255 stars 60 forks source link

does not identify ads on Facebook #6

Closed MovGP0 closed 7 years ago

MovGP0 commented 7 years ago

Ads on Facebook are not recognized when given in an non-english language.

facebook ad

storey commented 7 years ago

Is this only happening on non-English languages or on the English pages as well? In theory this should be a supported feature, e.g. I just grabbed this screenshot:

germanlanguage

I'll continue looking into it.

MovGP0 commented 7 years ago

it is not working on any ads. The HTTP header is set to accept-language:en-US,en;q=0.8,de;q=0.6,de-AT;q=0.4. Facebook language is set to de.

MovGP0 commented 7 years ago

Update: it works now :-)