search

citp / news-disinformation-study

A research project on how web users consume, are exposed to, and share news online.
8 stars 2 forks source link

Split the library modules from the news/disinformation study implementation #62

Closed jonathanmayer closed 4 years ago

jonathanmayer commented 4 years ago

Here's the repo layout concept, copy and pasted from Matrix:

  • We have a set of reusable library modules that live in one repo, along with reviews for those modules. (Roughly, everything that's currently in the WebScience directory / namespace.)
  • Each study lives in its own repo, along with reviews for the study. (Roughly, everything that's not in the WebScience directory / namespace.)
  • If a study wants to use the library modules, the study repo can pull in the library repo with Git subtree / submodule. That would (hopefully) a) avoid a re-review of the library modules for each study, b) minimize the amount of study-specific code that needs implementation and review, and c) (almost) automatically flow fixes and updates to the library modules down to the study repos.

@biancadanforth recommends using Git subtrees rather than submodules.

jonathanmayer commented 4 years ago

The split looks good. Could you please move Studies.js and Utilities.js over to this repo, and then we can close out this issue?

jonathanmayer commented 4 years ago

I took care of this in https://github.com/citp/news-disinformation-study/commit/7cf9bd504d6d051f8be6d19399725af57af6e9a8, https://github.com/citp/web-science/commit/58a6c391a7e0b11e17382761fed812ac9eb62337, https://github.com/citp/web-science/commit/adeb1c6d5ffd0db2b643dcdfd23f9faf069b2806, and https://github.com/citp/web-science/commit/6ae8dea4ea417a8f91d9dce2dcd5f09087c1755d. There were a bunch of fragile ES6 imports to get right. We shouldn't have to mess with this further.