search

citronalco / calibre-dnb

Calibre Plugin to download metadata and covers from DNB (Deutsche Nationalbibliothek)
GNU General Public License v3.0
10 stars 4 forks source link

Trying to fix cover download. #10

Closed beedaddy closed 8 months ago

beedaddy commented 8 months ago

For me, the cover download didn't work. I always got 'No cover found' in the log. I have no clue if I did the right thing, but I managed to get it work again. I think the problem was, that idn has never been set.

citronalco commented 8 months ago

Thanks for the report - and especially for digging through this messy code! It was the first thing I did with Python after "Hello World", so it has its edges....

idn is supposed to come from the saved metadata. book['idn'] is the one gathered during the "identify" phase, so this should be used for creating the cover URLs.

Can you please try https://github.com/citronalco/calibre-dnb/commit/b7b2c03bf8414485114cd33e4e181ac093471b95 (or branch https://github.com/citronalco/calibre-dnb/tree/cover_fix)?

beedaddy commented 8 months ago

Messy or not, this is one of my favourite plugins, so thanks a lot for this!

https://github.com/citronalco/calibre-dnb/commit/b7b2c03bf8414485114cd33e4e181ac093471b95 works perfectly!

citronalco commented 8 months ago

Fixed with b7b2c03bf8414485114cd33e4e181ac093471b95