search

citrus / spree_drop_shipping

under construction
BSD 3-Clause "New" or "Revised" License
22 stars 12 forks source link

Support Spree v1.0.1+ #4

Closed JDutil closed 11 years ago

JDutil commented 12 years ago

Added support for Spree v1.0.x and v.1.1.x

There is still 2 failing functional tests because I don't know how to make the tests use the proper controller route. Tested manually and everything is working though.

All the unit and cucumber tests are passing.

Going to be spending some more time on improving this as well since my spree app is going to entirely rely on drop shipping so this extensions going to be quite helpful. I'll see what I can do about fixing these last 2 functional tests, but everything I've found so far says you can't specify which controller the tests go against when they are namespaced.

JDutil commented 12 years ago

Yea I'm really stumped on how to properly do the functional controller tests. It would probably be easiest if they are simply redone in Cucumber instead.

JDutil commented 12 years ago

Well I've got good and bad news. Good news is I fixed the functional tests. The bad news is that for them to work the tests have to be run against Rails 3.2, which is only for Spree 1.1.x

So while technically this update works on Spree 1.0.x I've still bumped the Spree dependency to 1.1.x since thats what the tests took to pass. I've specified the git SHA reference in the Versionfile that people can use if they want to run this with 1.0.x though.

JDutil commented 12 years ago

Just pushed Spree 1.1.x fixes.

JDutil commented 11 years ago

Going to just work on http://github.com/jdutil/spree_drop_ship if anyone is interested in this work