search

citrus / spree_wholesale

A wholesale extension for Spree Commerce
http://rubygems.org/gems/spree_wholesale
BSD 3-Clause "New" or "Revised" License
36 stars 36 forks source link

Issues with edit/update #11

Closed tavon closed 12 years ago

tavon commented 12 years ago

SpreeWholesale::WholesalerController feels really brittle and needs to be refactored.

Currently, only new/create and edit/update is testing only for admin::wholesalers_controller. Adding a new wholesaler works well, but when I try to update a wholesaler, it fails pretty consistently. I believe the issues is with the Address models failing to update & associate with the Wholesaler object in #update...

We definitely need to add some more tests around the wholesalers controllers and should refactor it as well.

citrus commented 12 years ago

I completely agree, the wholesaler controller lib is a bit finicky and needs refactoring and more testing. I'll see if I can work on it a bit tonight.

tavon commented 12 years ago

I've made a pull request (#14) to solve this issue.